Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command line flag requirements installation #31255

Merged
merged 1 commit into from Oct 15, 2021
Merged

Fix command line flag requirements installation #31255

merged 1 commit into from Oct 15, 2021

Conversation

bashi
Copy link
Member

@bashi bashi commented Oct 15, 2021

The previous fix was wrong because venv should be the first item of args even when skip_venv_setup is specified.

@bashi bashi closed this Oct 15, 2021
@bashi bashi reopened this Oct 15, 2021
@bashi bashi closed this Oct 15, 2021
@bashi bashi reopened this Oct 15, 2021
@bashi bashi requested a review from foolip October 15, 2021 07:01
@bashi bashi marked this pull request as ready for review October 15, 2021 07:01
@bashi
Copy link
Member Author

bashi commented Oct 15, 2021

@foolip PTAL?
Context: The previous fix didn't work (e.g. https://ci.chromium.org/ui/p/chromium/builders/try/linux-wpt-identity-fyi-rel/4760/overview)

jgraham
jgraham approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops!

@jgraham jgraham merged commit 1f3d0a4 into web-platform-tests:master Oct 15, 2021
@bashi
Copy link
Member Author

bashi commented Oct 15, 2021

Thank you @jgraham!

@bashi bashi deleted the fix-conditional branch October 15, 2021 09:53
@foolip
Copy link
Member

foolip commented Oct 15, 2021

Thanks for fixing @bashi, sorry I was too slow again 😄

@bashi
Copy link
Member Author

bashi commented Oct 15, 2021

No one thinks responding within hours is slow 😄 Thank you for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@foolip foolip Awaiting requested review from foolip

Assignees

@foolip foolip

Labels
infra wpt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bashi @foolip @jgraham @wpt-pr-bot