WebKit export of https://bugs.webkit.org/show_bug.cgi?id=233834 #31893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 4, 2021
webkit-commit-queue
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Dec 10, 2021
… shadow tree https://bugs.webkit.org/show_bug.cgi?id=233834 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: Update the test per web-platform-tests/wpt#31893 as well as its expectations. * web-platform-tests/dom/events/event-global-expected.txt: * web-platform-tests/dom/events/event-global.html: Source/WebCore: This patch brings r233489 for JSErrorHandler (window.onerror handler for ErrorEvent), implementing the spec [1] and aligning WebKit with Blink and Gecko. [1] https://dom.spec.whatwg.org/#ref-for-window-current-event%E2%91%A1 Test: imported/w3c/web-platform-tests/dom/events/event-global.html * bindings/js/JSErrorHandler.cpp: (WebCore::JSErrorHandler::handleEvent): Canonical link: https://commits.webkit.org/245102@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
annulen
pushed a commit
to qtwebkit/qtwebkit
that referenced
this pull request
Dec 11, 2021
… shadow tree https://bugs.webkit.org/show_bug.cgi?id=233834 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: Update the test per web-platform-tests/wpt#31893 as well as its expectations. * web-platform-tests/dom/events/event-global-expected.txt: * web-platform-tests/dom/events/event-global.html: Source/WebCore: This patch brings r233489 for JSErrorHandler (window.onerror handler for ErrorEvent), implementing the spec [1] and aligning WebKit with Blink and Gecko. [1] https://dom.spec.whatwg.org/#ref-for-window-current-event%E2%91%A1 Test: imported/w3c/web-platform-tests/dom/events/event-global.html * bindings/js/JSErrorHandler.cpp: (WebCore::JSErrorHandler::handleEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@286871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream reviewed change ensures that
window.eventis not set bywindow.onerrorhandler if event's invocation target is in shadow tree.