Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO 2022-jp encoding and decoding tests #3199

Closed
wants to merge 2 commits into from
Closed

ISO 2022-jp encoding and decoding tests #3199

wants to merge 2 commits into from

Conversation

r12a
Copy link
Contributor

@r12a r12a commented Jun 20, 2016 •
edited by wpt-pr-bot

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6641

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@r12a r12a mentioned this pull request Jun 20, 2016
Closed
@r12a
fixed bug in encoder file due to recent changes wrt katakana
5a40b8b 
added timeout meta
removed tabs and line-end spaces
removed extraneous text
pointed to /common/blank.html
@w3c-bots
Copy link

w3c-bots commented Aug 11, 2017 •
edited

Build ERRORED

Started: 2017-08-11 15:25:26
Finished: 2017-08-11 15:52:50

View more information about this build on:

@r12a
Copy link
Contributor Author

r12a commented Aug 15, 2017

The last commit fixes the test bugs mentioned in whatwg/encoding#60

They also add the editorial changes that @domenic added elsewhere.

All tests now pass for Firefox 57. See https://www.w3.org/International/tests/repo/results/encoding-dbl-byte.en#iso2022jp. Hopefully this is now good to go.

@domenic domenic mentioned this pull request Nov 6, 2017
Merged
@domenic domenic closed this in #8071 Nov 6, 2017
@w3c-bots
Copy link

w3c-bots commented Nov 6, 2017

Build ERRORED

Started: 2017-08-11 15:25:26
Finished: 2017-08-11 15:52:50

Failing Jobs

  • lint
  • safari:10.0
  • MicrosoftEdge:14.14393

View more information about this build on:

domenic added a commit that referenced this pull request Nov 6, 2017
@domenic
ISO 2022-jp encoding and decoding tests
085f1d7 
Closes #3199, which this is an updated version of.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk Awaiting requested review from annevk

@inexorabletash inexorabletash Awaiting requested review from inexorabletash

Assignees
No one assigned
Labels
encoding stale:awaiting-review wg-i18n_core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r12a @hoppipolla-critic-bot @w3c-bots @sideshowbarker @wpt-pr-bot