ISO 2022-jp encoding and decoding tests #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added timeout meta removed tabs and line-end spaces removed extraneous text pointed to /common/blank.html
inexorabletash
approved these changes
Nov 6, 2017
| @@ -0,0 +1 @@ | |||
| Content-Type: text/html; charset=csiso2022jp | |||
There was a problem hiding this comment.
Can you add a trailing newline here and the other .headers files?
It looks like that was done for the shift_jis tests, and makes cating the files more pleasant
| } | ||
| } | ||
|
|
||
| function encode(input, expected, desc) { |
There was a problem hiding this comment.
Used in 5 test files; would be nice to factor it out but we can do that later.
There was a problem hiding this comment.
Yeah I think there's a general project to be done where you diff files in these encoding tests against each other and factor out large chunks, or use the .sub.html infrastructure to just make them into one test and then iframe N copies of them.
Build PASSEDStarted: 2017-11-06 04:02:25 Failing Jobs
View more information about this build on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was inspired to do another round of shepherding @r12a's tests through the process. This is an updated version of #3199 with fixes to make lint pass and JavaScript prettification.
It reportedly passes in Firefox 57, per #3199 (comment), so probably @hsivonen is happy with them at least, and we should merge them. Maybe @hsivonen or @inexorabletash can approve this so that, once CI passes, I can merge them.
Closes #3199.