Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tentative WPT tests for render-blocking elements #32669

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 3, 2022

This patch adds more WPT tests for:

  • Parser-inserted preload links
  • Script-inserted stylesheet and preload links
  • Script-inserted style elements

Bug: 1271296
Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967088}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This patch adds more WPT tests for:
- Parser-inserted preload links
- Script-inserted stylesheet and preload links
- Script-inserted style elements

Bug: 1271296
Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967088}
@DanielRyanSmith
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --no-headless --verify-log-full --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/html/dom/render-blocking/render-blocked-apis-by-preload-link.tentative.html Should not run the scroll steps when render-blocked FAIL: 2/10, PASS: 8/10 promise_test: Unhandled rejection with value: "'scroll' event is dispatched"

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@DanielRyanSmith
Copy link
Contributor

crbug/1294304 created. @past, can you force-merge this PR?

@xiaochengh
Copy link
Contributor

Hmm, this is a newly proposed feature, and I'm not expecting Firefox to pass it.

I'll look into it.

@past past merged commit d4f12e9 into master Feb 5, 2022
@past past deleted the chromium-export-cl-3435366 branch February 5, 2022 02:45
@past
Copy link
Member

past commented Feb 5, 2022

Merged, thanks!

mattwoodrow pushed a commit to mattwoodrow/wpt that referenced this pull request Feb 15, 2022
…rm-tests#32669)

This patch adds more WPT tests for:
- Parser-inserted preload links
- Script-inserted stylesheet and preload links
- Script-inserted style elements

Bug: 1271296
Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967088}

Co-authored-by: Xiaocheng Hu <xiaochengh@chromium.org>
DanielRyanSmith pushed a commit to DanielRyanSmith/wpt that referenced this pull request Feb 28, 2022
…rm-tests#32669)

This patch adds more WPT tests for:
- Parser-inserted preload links
- Script-inserted stylesheet and preload links
- Script-inserted style elements

Bug: 1271296
Change-Id: I8f6ffc6a191370410da56b64d7ff8dba852e2732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435366
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967088}

Co-authored-by: Xiaocheng Hu <xiaochengh@chromium.org>
foolip added a commit that referenced this pull request Nov 14, 2023
These tests were added in these PRs:
#32553
#32669
#32703
#32809
#33291
#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 30, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113

UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 30, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113

UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 30, 2023
…r tentative, a=testonly

Automatic update from web-platform-tests
Mark most render-blocking tests no longer tentative (#43113)

These tests were added in these PRs:
web-platform-tests/wpt#32553
web-platform-tests/wpt#32669
web-platform-tests/wpt#32703
web-platform-tests/wpt#32809
web-platform-tests/wpt#33291
web-platform-tests/wpt#33798

These were developed against HTML PRs which are now merged:
whatwg/html#7474
whatwg/html#7603
whatwg/html#7857
--

wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b
wpt-pr: 43113

UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants