[renderblocking] Don't cancel implicit render-blocking when blocking attribute is removed #33798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 26, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3608747
branch
3 times, most recently
from
ccb8ffa
to
2ccb413
Compare
…attribute is removed 1. This patch adds tests for whatwg/html#7857. When `blocking=render` is removed, if the element is implicitly render-blocking, we shouldn't unblock rendering for it. 2. This patch fixes how <link> element respond to `blocking` attribute changes. Previously, the element simply reprocesses (cancel and then restart) on every `blocking` attribute change, causing unnecessary work and also some bugs on stylesheets. This patch changes that into unblock rendering if needed to match the spec. Bug: 1271296 Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608747 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#998568}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3608747
branch
from
2ccb413
to
b9aa2eb
Compare
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Nov 13, 2023
These tests were added in the follow PRs: web-platform-tests#32553 web-platform-tests#32669 web-platform-tests#32703 web-platform-tests#32809 web-platform-tests#33291 web-platform-tests#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857
foolip
added a commit
to foolip/wpt
that referenced
this pull request
Nov 13, 2023
These tests were added in these PRs: web-platform-tests#32553 web-platform-tests#32669 web-platform-tests#32703 web-platform-tests#32809 web-platform-tests#33291 web-platform-tests#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857
foolip
added a commit
that referenced
this pull request
Nov 14, 2023
These tests were added in these PRs: #32553 #32669 #32703 #32809 #33291 #33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
…r tentative, a=testonly Automatic update from web-platform-tests Mark most render-blocking tests no longer tentative (#43113) These tests were added in these PRs: web-platform-tests/wpt#32553 web-platform-tests/wpt#32669 web-platform-tests/wpt#32703 web-platform-tests/wpt#32809 web-platform-tests/wpt#33291 web-platform-tests/wpt#33798 These were developed against HTML PRs which are now merged: whatwg/html#7474 whatwg/html#7603 whatwg/html#7857 -- wpt-commits: aa6bdcbb00f30914b87794cf82b015fc02d4cc5b wpt-pr: 43113 UltraBlame original commit: 58cb91eda01d9227e0e02791aa6562da04967a42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds tests for Don't unblock rendering for implicitly render-blocking elements on
blockingattribute changes whatwg/html#7857.When
blocking=renderis removed, if the element is implicitlyrender-blocking, we shouldn't unblock rendering for it.
This patch fixes how <link> element respond to
blockingattributechanges. Previously, the element simply reprocesses (cancel and then
restart) on every
blockingattribute change, causing unnecessarywork and also some bugs on stylesheets. This patch changes that into
unblock rendering if needed to match the spec.
Bug: 1271296
Change-Id: I54a2f33dc1ed9971eaeceeb677a165d598d5d4d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3608747
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#998568}