Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that time in beforeunload does not affect navigation start time #33227

Merged
merged 2 commits into from May 4, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 17, 2022

@noamr noamr requested a review from yoavweiss March 17, 2022 13:44
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plehegar plehegar removed their request for review March 25, 2022 19:33
@plehegar plehegar removed their assignment Mar 25, 2022
@domenic
Copy link
Member

domenic commented May 3, 2022

@noamr any way to avoid flakes in Firefox Nightly? Or should we just admin-merge this because it's testing something where flakes are expected for non-spec-conforming browsers?

@noamr
Copy link
Contributor Author

noamr commented May 3, 2022

@noamr any way to avoid flakes in Firefox Nightly? Or should we just admin-merge this because it's testing something where flakes are expected for non-spec-conforming browsers?

It's hard to make it consistently fail on Firefox. So perhaps admin-merge is the way to go.

@Ms2ger Ms2ger merged commit 34cafd7 into master May 4, 2022
@Ms2ger Ms2ger deleted the navigation-start-beforeunload branch May 4, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants