Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ruby] Adding japanese .woff font resource into block-ruby-001 test and reference #33271

Merged
merged 2 commits into from Apr 4, 2022

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Mar 19, 2022

@TalbotG TalbotG self-assigned this Mar 19, 2022
@TalbotG TalbotG changed the title [css-ruby] Replaced japanese char. with latin char. in block-ruby-001 test and reference [css-ruby] Adding japanese .woff font resource into block-ruby-001 test and reference Apr 1, 2022
@TalbotG
Copy link
Contributor Author

TalbotG commented Apr 1, 2022

@TalbotG TalbotG requested review from jgraham and himorin April 1, 2022 19:23
@himorin
Copy link
Contributor

himorin commented Apr 4, 2022

Looking at results and diff, I confirm lines for woff inclusion are ok and correctly working.

@TalbotG TalbotG merged commit e7c6566 into web-platform-tests:master Apr 4, 2022
@TalbotG
Copy link
Contributor Author

TalbotG commented Apr 4, 2022

Thank you, @himorin .
At the bottom of the results and diff page you mentioned, it is written
https://crbug.com/27659
but I think it should be
https://crbug.com/1079135
Issue 1079135: Support |display: block ruby| behavior

@TalbotG TalbotG deleted the CSS3Ruby-GT-PR13 branch April 4, 2022 12:49
@himorin
Copy link
Contributor

himorin commented Apr 12, 2022

Thank you, @himorin . At the bottom of the results and diff page you mentioned,

afaiu, that link should come from
https://github.com/web-platform-tests/wpt-metadata/blob/615cb9982b7a19a491515ca5d9e5df0210db13d6/css/css-ruby/META.yml#L21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants