Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing virtualenv when building command line parser for docs #33588

Merged
merged 1 commit into from Apr 13, 2022

Conversation

jgraham
Copy link
Contributor

@jgraham jgraham commented Apr 11, 2022

This fixes building docs in the docker container.

This fixes building docs in the docker container.
@DanielRyanSmith
Copy link
Contributor

DanielRyanSmith commented Apr 11, 2022

Tangentially related as I'm seeing the same failures in your CI run,

Your CI failure seems to be related to the timeout set for checking if the webtransport HTTP/3 server is running here:

if not webtranport_h3_server_is_running(host, port, timeout=1.0):
# TODO(bashi): Consider supporting retry.
failed.append((host, port))

I've been testing for Python 3.10 compatibility and for some reason this check times out much more regularly on Py3.10, which had me very confused and thinking it was a compatibility issue. Increasing this timeout eliminated this failure (for testing I increased to 5.0). It's possible we just need to increase the timeout here so these occasional unrelated failures don't happen.

@jgraham jgraham merged commit 2585ae8 into master Apr 13, 2022
@jgraham jgraham deleted the docs_build branch April 13, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants