Use None to signal adb binary default for chrome_android-related products
#33669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
The change #33654 caused `chrome_android`-related runs without `--adb-binary` to fail because the corresponding kwarg was `None` but present. Constructing the browser overwrote the kwarg default. This change fixes that bug by using `None` to signal default `adb` usage.
jonathan-j-lee
force-pushed
the
chromium-fix-null-adb
branch
from
dbda5e7
to
53d75c0
Compare
WeizhongX
approved these changes
Apr 18, 2022
jonathan-j-lee
changed the title
--adb-binary defaultNone to signal adb binary default for chrome_android-related products
DanielRyanSmith
pushed a commit
to DanielRyanSmith/wpt
that referenced
this pull request
Apr 27, 2022
…d products (web-platform-tests#33669) The change web-platform-tests#33654 caused `chrome_android`-related runs without `--adb-binary` to fail because the corresponding kwarg was `None` but present. Constructing the browser overwrote the kwarg default. This change fixes that bug by using `None` to signal default `adb` usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #33654 caused
chrome_android-related runs without--adb-binaryto fail because the corresponding kwarg wasNonebut present. Constructing the browser overwrote the kwarg default.This change fixes that bug by using
Noneto signal defaultadbusage.This time, I tested the change on the
run_monochrome_webview_finch_smoke_teststarget in Chromium as well, which does not pass--adb-binaryto wptrunner.