[@scope] Evaluate scoped rules in SelectorChecker #33740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 21, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3582131
branch
from
e012b5c
to
4aab368
Compare
This CL propagates the enclosing StyleScope (if any) to SelectorChecker, such that we can perform an additional check (CheckInStyleScope) to see if the subject element is in scope. Several different approaches were considered, but in order to remain agile with regards to the different paths the css-cascade-6 specification might take from this point, I opted to handle it entirely within SelectorChecker, even if other approaches may be more efficient. It is more important that the prototype is able to handle alternative entry points to the feature (if needed) than it is to have the best possible performance right away. Many performance optimizations are planned as follow-ups, most notably: - Making use of the fast reject filter. - Multiple StyleScopeFrames with longer lifetimes. Note also that addressing the following is deferred to future CLs: - ShadowDOM - Invalidation Bug: 1280240 Change-Id: I050e7d8249688ae6d6d67431dceca5eabfbcc7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3582131 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#995669}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3582131
branch
from
4aab368
to
47670a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL propagates the enclosing StyleScope (if any) to
SelectorChecker, such that we can perform an additional check
(CheckInStyleScope) to see if the subject element is in scope.
Several different approaches were considered, but in order to remain
agile with regards to the different paths the css-cascade-6
specification might take from this point, I opted to handle it
entirely within SelectorChecker, even if other approaches may be
more efficient. It is more important that the prototype is able to
handle alternative entry points to the feature (if needed) than it
is to have the best possible performance right away.
Many performance optimizations are planned as follow-ups, most
notably:
Note also that addressing the following is deferred to future CLs:
Bug: 1280240
Change-Id: I050e7d8249688ae6d6d67431dceca5eabfbcc7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3582131
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995669}