Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@scope] Evaluate scoped rules in SelectorChecker #33740

Merged
merged 1 commit into from Apr 25, 2022

Commits on Apr 25, 2022

  1. [@scope] Evaluate scoped rules in SelectorChecker

    This CL propagates the enclosing StyleScope (if any) to
    SelectorChecker, such that we can perform an additional check
    (CheckInStyleScope) to see if the subject element is in scope.
    
    Several different approaches were considered, but in order to remain
    agile with regards to the different paths the css-cascade-6
    specification might take from this point, I opted to handle it
    entirely within SelectorChecker, even if other approaches may be
    more efficient. It is more important that the prototype is able to
    handle alternative entry points to the feature (if needed) than it
    is to have the best possible performance right away.
    
    Many performance optimizations are planned as follow-ups, most
    notably:
    
     - Making use of the fast reject filter.
     - Multiple StyleScopeFrames with longer lifetimes.
    
    Note also that addressing the following is deferred to future CLs:
    
     - ShadowDOM
     - Invalidation
    
    Bug: 1280240
    Change-Id: I050e7d8249688ae6d6d67431dceca5eabfbcc7fc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3582131
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#995669}
    andruud authored and chromium-wpt-export-bot committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    47670a0 View commit details
    Browse the repository at this point in the history