[Gecko Bug 1780444] part 2: Add tests to ensure that text can be rendered in a textbox's inline-end padding area, but not in its inline-start padding area. #34929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inline-end padding area, but not in its inline-start padding area. (The inline-start test is kind of trivial; it's mostly there for symmetry/completeness.) I don't think the inline-end behavior is spelled out in any spec, but it seems to be the consensus behavior among browsers at this point. Hence, I'm adding the testcases with ".tentative" naming, due to the lack of authoritative spec-text here. I'll add block-axis equivalents of these tests in a subsequent patch. Differential Revision: https://phabricator.services.mozilla.com/D152330 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780444 gecko-commit: a72984b399f7ab8911531c26644e37e2a97b8309 gecko-reviewers: emilio
… validate that text can render in block-end padding but not block-start padding. This patch was mostly generated automatically (based off of neighboring tests), using the following bash script (executed in the "the-textarea-element" directory): ``` for inlineVer in ./textarea-padding-i*; do blockVer=`echo $inlineVer | sed "s/padding-i/padding-b/"` hg cp $inlineVer $blockVer # Fix the link tags pointing to reference cases: sed -i s/-istart-/-bstart-/g $blockVer sed -i s/-iend-/-bend-/g $blockVer # Swap "block" and "inline" terminology throughout the new copy: sed -i s/block/TEMPORARY-FOO/g $blockVer sed -i s/inline/block/g $blockVer sed -i s/TEMPORARY-FOO/inline/g $blockVer done ``` After running that script, I added one additional "overflow:hidden" declaration to the generated "textarea-padding-bend-overlaps-content-001.tentative.html" file (and an explanatory comment), to suppress scrollbars that get generated specifically for block-axis end-edge padding overflow. Differential Revision: https://phabricator.services.mozilla.com/D152332 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780444 gecko-commit: fb5353c55f7a9f79ede9ed97916ebf2a1b6d5372 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The inline-start test is kind of trivial; it's mostly there for
symmetry/completeness.)
I don't think the inline-end behavior is spelled out in any spec, but it seems
to be the consensus behavior among browsers at this point. Hence, I'm adding
the testcases with ".tentative" naming, due to the lack of authoritative
spec-text here.
I'll add block-axis equivalents of these tests in a subsequent patch.
Differential Revision: https://phabricator.services.mozilla.com/D152330
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780444
gecko-commit: a72984b399f7ab8911531c26644e37e2a97b8309
gecko-reviewers: emilio