Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1780444] part 2: Add tests to ensure that text can be rendered in a textbox's inline-end padding area, but not in its inline-start padding area. #34929

Merged
merged 2 commits into from
Jul 22, 2022
Merged

[Gecko Bug 1780444] part 2: Add tests to ensure that text can be rendered in a textbox's inline-end padding area, but not in its inline-start padding area. #34929

merged 2 commits into from
Jul 22, 2022

Commits on Jul 21, 2022

  1. part 2: Add tests to ensure that text can be rendered in a textbox's … 

    …inline-end padding area, but not in its inline-start padding area.

(The inline-start test is kind of trivial; it's mostly there for
symmetry/completeness.)

I don't think the inline-end behavior is spelled out in any spec, but it seems
to be the consensus behavior among browsers at this point.  Hence, I'm adding
the testcases with ".tentative" naming, due to the lack of authoritative
spec-text here.

I'll add block-axis equivalents of these tests in a subsequent patch.

Differential Revision: https://phabricator.services.mozilla.com/D152330

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780444
gecko-commit: a72984b399f7ab8911531c26644e37e2a97b8309
gecko-reviewers: emilio
    @dholbert @moz-wptsync-bot
    dholbert authored and moz-wptsync-bot committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    9e2c105 View commit details
    Browse the repository at this point in the history

  2. part 3: Add block-axis variants of textarea text-in-padding tests, to… 

    … validate that text can render in block-end padding but not block-start padding.

This patch was mostly generated automatically (based off of neighboring tests),
using the following bash script (executed in the "the-textarea-element"
directory):

```
for inlineVer in ./textarea-padding-i*; do
  blockVer=`echo $inlineVer | sed "s/padding-i/padding-b/"`
  hg cp $inlineVer $blockVer
  # Fix the link tags pointing to reference cases:
  sed -i s/-istart-/-bstart-/g $blockVer
  sed -i s/-iend-/-bend-/g $blockVer
  # Swap "block" and "inline" terminology throughout the new copy:
  sed -i s/block/TEMPORARY-FOO/g $blockVer
  sed -i s/inline/block/g $blockVer
  sed -i s/TEMPORARY-FOO/inline/g $blockVer
done
```

After running that script, I added one additional "overflow:hidden" declaration
to the generated "textarea-padding-bend-overlaps-content-001.tentative.html"
file (and an explanatory comment), to suppress scrollbars that get generated
specifically for block-axis end-edge padding overflow.

Differential Revision: https://phabricator.services.mozilla.com/D152332

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1780444
gecko-commit: fb5353c55f7a9f79ede9ed97916ebf2a1b6d5372
gecko-reviewers: emilio
    @dholbert @moz-wptsync-bot
    dholbert authored and moz-wptsync-bot committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    e6a1a62 View commit details
    Browse the repository at this point in the history