Actions API x/y params must be integers #35942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the pointerMove and scroll Actions API functions, the coordinate parameters must be integers. Let's update the documentation to mention this Reference: - https://www.w3.org/TR/webdriver/#dfn-process-a-pointer-action - https://www.w3.org/TR/webdriver/#dfn-process-a-wheel-action
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 18, 2022
On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: #35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 19, 2022
On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: web-platform-tests/wpt#35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3903489 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Andrew Williams <awillia@google.com> Cr-Commit-Position: refs/heads/main@{#1048493}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: #35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3903489 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Andrew Williams <awillia@google.com> Cr-Commit-Position: refs/heads/main@{#1048493}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Sep 19, 2022
On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: #35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3903489 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Andrew Williams <awillia@google.com> Cr-Commit-Position: refs/heads/main@{#1048493}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 24, 2022
…s to pointerMove, a=testonly Automatic update from web-platform-tests Update mouseMoveToCenter to pass integers to pointerMove On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: web-platform-tests/wpt#35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3903489 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Andrew Williams <awillia@google.com> Cr-Commit-Position: refs/heads/main@{#1048493} -- wpt-commits: 6359e0968f840c9bd76b8c4dd97e8494714dfed3 wpt-pr: 35944
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Sep 27, 2022
…s to pointerMove, a=testonly Automatic update from web-platform-tests Update mouseMoveToCenter to pass integers to pointerMove On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: web-platform-tests/wpt#35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3903489 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Andrew Williams <awillia@google.com> Cr-Commit-Position: refs/heads/main@{#1048493} -- wpt-commits: 6359e0968f840c9bd76b8c4dd97e8494714dfed3 wpt-pr: 35944
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
On wpt.fyi the newly automated drag and drop WPTs currently fail with errors like: Expected 'x' ([object Number] 71.5) to be an Integer Ex: https://wpt.fyi/results/html/editing/dnd/images/006.html?label=master&label=experimental&aligned&view=subtest This CL updates the mouseMoveToCenter drag and drop helper function to ensure that the x and y coordinates passed to the Actions API pointerMove function are always integers. I also submitted a PR to update the docs so that they mention this requirement: web-platform-tests/wpt#35942 Bug: 1302171 Change-Id: I91ec54fa778774ac25feb47454259769f2742514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3903489 Reviewed-by: Mike Taylor <miketaylr@chromium.org> Commit-Queue: Andrew Williams <awillia@google.com> Cr-Commit-Position: refs/heads/main@{#1048493} NOKEYCHECK=True GitOrigin-RevId: 8f67b8c577e4a36950f8d48c45ec2fe7dcac0640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the pointerMove and scroll Actions API functions, the coordinate parameters must be integers. Let's update the documentation to mention this
Reference: