Request upload: test synchronous feature detect #36048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2022
lucacasonato
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
The code itself looks good to me, but I am not sure if this will actually have the intended outcome, as the implementer may just see this as "just another test failure for an unimplemented feature".
I can't think of anything better, and it definitely does not do any harm, so let's just land it.
annevk
approved these changes
Sep 26, 2022
| assert_true(duplexAccessed, `duplex dictionary property should be accessed`); | ||
| }, "Synchronous feature detect"); | ||
|
|
||
| // The asserts the synchronousFeatureDetect isn't broken by a partial implementation. |
There was a problem hiding this comment.
Suggested change
| // The asserts the synchronousFeatureDetect isn't broken by a partial implementation. | |
| // This asserts the synchronousFeatureDetect isn't broken by a partial implementation. |
?
There was a problem hiding this comment.
I forgot about this nit... Maybe fix in a follow-up?
|
FWIW, I suspect as part of implementing Fetch features WebKit would sync |
annevk
pushed a commit
to whatwg/fetch
that referenced
this pull request
Sep 26, 2022
Oversight of #1457. Tests: web-platform-tests/wpt#36051 & web-platform-tests/wpt#36048. Closes #1486.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: WebKit/standards-positions#24 (comment)