[Gecko Bug 1791332] Add an OPFS-specific synchronous ordered cleanup queue #36182
+54
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default test.add_cleanup() code from testharness.js in wpt executes the cleanups in parallel, and even if it wasn't in parallel it would be in FIFO order (the wrong order). This adds an OPFS-specific cleanup queue called once from the test cleanup list, and we process the list synchronously in LIFO order. Depends on D146203 Differential Revision: https://phabricator.services.mozilla.com/D157606 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791332 gecko-commit: 388419886525a4b8d6be986bc890f09e6c16052d gecko-reviewers: asuth, dom-storage-reviewers
wpt-pr-bot
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default test.add_cleanup() code from testharness.js in wpt executes the
cleanups in parallel, and even if it wasn't in parallel it would be in FIFO
order (the wrong order).
This adds an OPFS-specific cleanup queue called once from the test cleanup
list, and we process the list synchronously in LIFO order.
Depends on D146203
Differential Revision: https://phabricator.services.mozilla.com/D157606
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1791332
gecko-commit: 388419886525a4b8d6be986bc890f09e6c16052d
gecko-reviewers: asuth, dom-storage-reviewers