fetch, Web IDL: Test that Headers iteration happens on live value pairs. #36455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some tests to verify the pair iterator behavior specified in Web IDL, namely that the value pairs to be iterated over are retrieved on every invocation of the iterator prototype object's `next()` function. In practice, this means that every iteration step needs to be performed on a Headers' sorted-and-combined headers list that should not be cached. Gecko seems to be the only engine doing this right, as both WebKit and Blink appear to carry out the entire iteration on a cached copy of the header list. The tests were based on the ones in webidl/ecmascript-binding/iterator-invalidation-foreach.html.
|
@annevk I'm tentatively assigning to you because you're involved with both Fetch and Web IDL. I wasn't sure if it made sense to add these new tests to |
annevk
approved these changes
Oct 14, 2022
* Use `() => {}` form for inner test functions.
* Stop breaking declaration of `headers` into multiple lines.
* Use `const` in the for..of loop.
* Improve description of the last test.
rakuco
added a commit
to rakuco/wpt
that referenced
this pull request
Oct 18, 2022
This is similar to web-platform-tests#36455 and web-platform-tests#20445: we want to make sure that adding and deleting elements during iteration is reflected in FormData's value pairs to iterate over (i.e. iteration does not happen on a cached version).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some tests to verify the pair iterator behavior specified in Web IDL, namely that the value pairs to be iterated over are retrieved on every invocation of the iterator prototype object's
next()function.In practice, this means that every iteration step needs to be performed on a Headers' sorted-and-combined headers list that should not be cached. Gecko seems to be the only engine doing this right, as both WebKit and Blink appear to carry out the entire iteration on a cached copy of the header list.
The tests were based on the ones in
webidl/ecmascript-binding/iterator-invalidation-foreach.html.