Referrer Policy: Test image loads inside srcdoc frames. #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch teaches the 'img-tag'-style tests to load an image both in the top-level document, and inside a 'srcdoc' frame. The referrer should be the same in both places. Addresses #2851.
|
Reviewers for this pull request are: @kristijanburnik. |
|
@bzbarsky: Are you happy with this? If so, I'll merge it. |
|
Yes, this seems reasonable in general. For dynamic referrer policy changes (e.g. dynamic meta tag insertion?), it would be nice to test the situation in which the srcdoc iframe is created and loaded before the dynamic mutation happens. But we can push that off into a separate issue; it seems like a good bit of work to do. |
|
@mikewest ping -- is this ready to merge? It addresses w3c/webappsec-referrer-policy#57. |
|
Thanks for the ping, Emily! |
estark37
added a commit
to estark37/web-platform-tests
that referenced
this pull request
Nov 18, 2016
…licies This commit modifies the img-tag referrer policy tests to test a srcdoc iframe with its own referrer policy set via <meta> tag, adding on to the existing tests for srcdoc iframes that inherit the referrer policy of their parent document. The corresponding HTML change is whatwg/html#1871. This also corrects a bug in web-platform-tests#3700, which was comparing undefined to undefined (using the 'referrer' property of image data, when it should be headers.referer).
mikewest
pushed a commit
that referenced
this pull request
Nov 19, 2016
This commit modifies the img-tag referrer policy tests to test a srcdoc iframe with its own referrer policy set via <meta> tag, adding on to the existing tests for srcdoc iframes that inherit the referrer policy of their parent document. The corresponding HTML change is whatwg/html#1871. This also corrects a bug in #3700, which was comparing undefined to undefined (using the 'referrer' property of image data, when it should be headers.referer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch teaches the 'img-tag'-style tests to load an image both
in the top-level document, and inside a 'srcdoc' frame. The referrer
should be the same in both places.
Addresses #2851.