Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPC] Add Secure Payment Confirmation opt out WPT #37012

Merged
merged 1 commit into from
Nov 18, 2022

Commits on Nov 18, 2022

  1. [SPC] Add Secure Payment Confirmation opt out WPT

    Adds chromedriver support and web platform test for opt-out for SPC. The
    WPT passes locally with SPC opt out enabled (currently disabled behind a
    flag).
    
    There's a small change in the SPC MVC logic, since opt-out can now
    happen by calling SPCController::OnOptOut directly, which resulted in
    the dialog view calling back to OnCancel when the dialog closes since it
    didn't know opt-out was programmatically invoked. This is fixed by
    having the controller set a bit on the model which the view checks.
    
    Spec PR: w3c/secure-payment-confirmation#215
    
    Bug: 1385865
    Change-Id: I777e92b5110785415de68ef9f0497905598e4897
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030688
    Commit-Queue: Nick Burris <nburris@chromium.org>
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1073462}
    nickburris authored and chromium-wpt-export-bot committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    03aff36 View commit details
    Browse the repository at this point in the history