[SPC] Add Secure Payment Confirmation opt out WPT #37012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 17, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4030688
branch
from
b09c517
to
c4b26a3
Compare
Adds chromedriver support and web platform test for opt-out for SPC. The WPT passes locally with SPC opt out enabled (currently disabled behind a flag). There's a small change in the SPC MVC logic, since opt-out can now happen by calling SPCController::OnOptOut directly, which resulted in the dialog view calling back to OnCancel when the dialog closes since it didn't know opt-out was programmatically invoked. This is fixed by having the controller set a bit on the model which the view checks. Spec PR: w3c/secure-payment-confirmation#215 Bug: 1385865 Change-Id: I777e92b5110785415de68ef9f0497905598e4897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030688 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073462}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4030688
branch
from
c4b26a3
to
03aff36
Compare
stephenmcgruer
pushed a commit
to w3c/secure-payment-confirmation
that referenced
this pull request
Dec 9, 2022
This PR adds spec text for a new showOptOut option in the SecurePaymentConfirmationRequest API. See the original proposal and discussion in #172. This spec change reflects the prototype currently implemented behind a flag in Chrome, which is available via origin trial and used in this test page. The OptOutError mentioned in this change is being added to WebIDL in whatwg/webidl#1231. Opt-out web platform test: web-platform-tests/wpt#37012 Fixes #172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds chromedriver support and web platform test for opt-out for SPC. The
WPT passes locally with SPC opt out enabled (currently disabled behind a
flag).
There's a small change in the SPC MVC logic, since opt-out can now
happen by calling SPCController::OnOptOut directly, which resulted in
the dialog view calling back to OnCancel when the dialog closes since it
didn't know opt-out was programmatically invoked. This is fixed by
having the controller set a bit on the model which the view checks.
Spec PR: w3c/secure-payment-confirmation#215
Bug: 1385865
Change-Id: I777e92b5110785415de68ef9f0497905598e4897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030688
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1073462}