Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML: comment and PI in doctype internal subset #38136

Merged
merged 2 commits into from Jan 26, 2023
Merged

XML: comment and PI in doctype internal subset #38136

merged 2 commits into from Jan 26, 2023

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Jan 24, 2023

Per the XML Information Set spec, comments in the doctype are not represented and PIs are children of the doctype. The DOM does not allow children of DocumentType nodes. Therefore, in the DOM, they should not be represented.

@zcorpan
XML: comment and PI in doctype internal subset
cffb77c 
Per the XML Information Set spec, comments in the doctype are not represented and PIs are children of the doctype. The DOM does not allow children of DocumentType nodes. Therefore, in the DOM, they should not be represented.
@zcorpan zcorpan requested a review from annevk January 24, 2023 12:56
annevk
annevk approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if there are no references to the infoset, which I think we ought to largely ignore in favor of the combination of the HTML Standard, DOM Standard, and XML + XMLNS standards.

zcorpan
zcorpan commented Jan 26, 2023
View reviewed changes
css/cssom/xml-stylesheet-pi-in-doctype.xhtml Outdated Show resolved Hide resolved
dom/nodes/Comment-in-doctype.xhtml Outdated Show resolved Hide resolved
dom/nodes/ProcessingInstruction-in-doctype.xhtml Outdated Show resolved Hide resolved
@zcorpan zcorpan enabled auto-merge (squash) January 26, 2023 15:54
@zcorpan zcorpan merged commit 8e07a86 into master Jan 26, 2023
@zcorpan zcorpan deleted the xml-pi-in-doctype branch January 26, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@dbaron dbaron Awaiting requested review from dbaron

@jdm jdm Awaiting requested review from jdm

@lilles lilles Awaiting requested review from lilles

@plinss plinss Awaiting requested review from plinss

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@plinss plinss

Labels
cssom dom wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zcorpan @annevk @plinss @wpt-pr-bot