Test priority of blob.type and headers content-type for blob() #39489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If those 3 tests are not in WPT it's worth adding them to WPT. And then it's probably not worth adding them separately to LayoutTests. No need to have duplicate tests and WPT is preferable. |
annevk
approved these changes
Apr 13, 2023
|
@annevk thanks for confirmation 🙏 I just added other remaining tests in the WebKit LayoutTests test into this PR. |
|
I just noticed there was some errors in previous commit so I just fixed them. I think this is ready for another review now 🙇 |
|
@annevk should I wait for whatwg/fetch#1630 fixed to land this PR? or, do I need another reviewers' approval? |
annevk
approved these changes
Apr 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would add the tests for whatwg/fetch#1630. They are basically moved from Chromium and WebKit but changed a bit to test both request and response.
(but I wonder maybe it's worth also adding another 3 tests in the webkit test in this PR?)