Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bidi: remove tlsEnd from network.FetchTimingInfo #40223

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

thiagowfx
Copy link
Member

tlsEnd never made it to the spec:
https://w3c.github.io/webdriver-bidi/#type-network-FetchTimingInfo

c.f. w3c/webdriver-bidi#204:

tlsEnd: float this should be the same as connectEnd

As it is a redundant param anyway, remove it from WPT.

tlsEnd never made it to the spec:
https://w3c.github.io/webdriver-bidi/#type-network-FetchTimingInfo

c.f. w3c/webdriver-bidi#204:

> tlsEnd: float this should be the same as connectEnd

As it is a redundant param anyway, remove it from WPT.
@jgraham
Copy link
Contributor

jgraham commented May 25, 2023

Or I guess here is a better place to ping @juliandescottes

Copy link
Contributor

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes that sounds correct. Not sure why I kept it in the implementation, maybe it was still in the PR when I made the implementation. In any case, removing it from the tests sounds fine.

@thiagowfx thiagowfx enabled auto-merge (squash) May 25, 2023 13:40
@thiagowfx thiagowfx merged commit 1d68446 into master May 25, 2023
17 checks passed
@thiagowfx thiagowfx deleted the thiagowfx/network branch May 25, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants