[Gecko Bug 1528042] Limit enumerateDevices() fingerprinting vector ahead of (and after) getUserMedia success, to spec. #40263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etUserMedia success, to spec. Updates enumerateDevices() to limit exposure of privacy sensitive information ahead of actual camera or microphone use. It also implements the "creating a device info object" algorithm correctly after getUserMedia success, which only exposes information on cameras or microphones (but not both) if only one or the other kind has successfully been used. Includes the latest privacy improvements to the spec: - w3c/mediacapture-main#632 - w3c/mediacapture-main#641 - w3c/mediacapture-main#773 This also fixes media.navigator.permission.disabled leaking labels. Differential Revision: https://phabricator.services.mozilla.com/D100378 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528042 gecko-commit: 55c6b85b37c1fb8d6d0b6a273e237b4921672743 gecko-reviewers: karlt
For now legacy is enabled. Differential Revision: https://phabricator.services.mozilla.com/D154139 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528042 gecko-commit: b47fdabb6f8659aa7671ee9c9b83668bfe307914 gecko-reviewers: karlt
…ontinue to test full device information exposure in enumerateDevices(). This is required by spec. See w3c/mediacapture-main#641 and w3c/mediacapture-main#773 for details. Also fixes test_enumerateDevices_getUserMediaFake.html to run on macOS outside automation. Differential Revision: https://phabricator.services.mozilla.com/D154302 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528042 gecko-commit: 173f133fb868ce50a9feec4e26496be7f7aeae11 gecko-reviewers: karlt
Differential Revision: https://phabricator.services.mozilla.com/D155430 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528042 gecko-commit: 6c8c76da9ab72b9901733e6475496c83fea9988c gecko-reviewers: karlt
…posed for that kind per w3c/mediacapture-main#900. Differential Revision: https://phabricator.services.mozilla.com/D176925 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528042 gecko-commit: 364f837033b89f56f75b4ec40d839fcdbd1693d8 gecko-reviewers: karlt
wpt-pr-bot
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates enumerateDevices() to limit exposure of privacy sensitive
information ahead of actual camera or microphone use.
It also implements the "creating a device info object" algorithm correctly
after getUserMedia success, which only exposes information on cameras or
microphones (but not both) if only one or the other kind has successfully
been used.
Includes the latest privacy improvements to the spec:
This also fixes media.navigator.permission.disabled leaking labels.
Differential Revision: https://phabricator.services.mozilla.com/D100378
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528042
gecko-commit: 55c6b85b37c1fb8d6d0b6a273e237b4921672743
gecko-reviewers: karlt