WebKit export of https://bugs.webkit.org/show_bug.cgi?id=257397 #40325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+. |
annevk
reviewed
May 31, 2023
| @@ -13,10 +14,10 @@ | |||
| <script> | |||
| test(function() { | |||
| var client = new XMLHttpRequest(), | |||
| urlstart = 'www1.'+location.host + location.pathname.replace(/\/[^\/]*$/, '/') | |||
| urlstart = get_host_info().REMOTE_ORIGIN + location.pathname.replace(/\/[^\/]*$/, '/') | |||
There was a problem hiding this comment.
No need for double space after equals sign, but also no need to address. This whole file looks kinda bad anyway :-)
| @@ -17,7 +17,7 @@ | |||
| { | |||
| var xhr = new XMLHttpRequest(); | |||
|
|
|||
| xhr.open("POST", "http://nonexistent.{{host}}:{{ports[http][0]}}", false); | |||
| xhr.open("POST", "http://{{host}}:3", false); // Bad port. | |||
There was a problem hiding this comment.
3 is fine per https://fetch.spec.whatwg.org/#bad-port. Use 1?
cdumez
force-pushed
the
webkit_pr_14406_export
branch
from
91e3128
to
1bcb46a
Compare
wpt-pr-bot
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use get-host-info.sub.js to make the tests work with the WebKit test infrastructure.