[Topics] Refactor header to be easier to read and parse #40332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 31, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4576009
branch
4 times, most recently
from
0028d2b
to
9c3ab5d
Compare
Changed the format of the topics request header from: "t=(1;v=chrome.1:1:2, 2), p=P00000" to "(1 2);v=chrome.1:1:2, ();p=P00000" As discussed in patcg-individual-drafts/topics#183 Bug: 1443540 Change-Id: I3ea40df9f8732f5eff953110f22f4da2163480fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576009 Reviewed-by: Yao Xiao <yaoxia@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1151938}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4576009
branch
from
9c3ab5d
to
2f0a8b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the format of the topics request header from:
"t=(1;v=chrome.1:1:2, 2), p=P00000" to
"(1 2);v=chrome.1:1:2, ();p=P00000"
As discussed in patcg-individual-drafts/topics#183
Bug: 1443540
Change-Id: I3ea40df9f8732f5eff953110f22f4da2163480fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4576009
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1151938}