Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1846635] [css-properties-values-api] Support <string> syntax #41308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Gecko Bug 1846635] [css-properties-values-api] Support <string> syntax #41308

wants to merge 1 commit into from

Conversation

moz-wptsync-bot
Copy link
Collaborator

Differential Revision: https://phabricator.services.mozilla.com/D185203

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846635
gecko-commit: 168ad53da9fdaa993c4f26b252848fb8e76169aa
gecko-reviewers: emilio

@zrhoffman @moz-wptsync-bot
[css-properties-values-api] Support <string> syntax
7afbd5e 
Differential Revision: https://phabricator.services.mozilla.com/D185203

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846635
gecko-commit: 168ad53da9fdaa993c4f26b252848fb8e76169aa
gecko-reviewers: emilio
wpt-pr-bot
wpt-pr-bot approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@lilles
Copy link
Member

lilles commented Aug 3, 2023

There is no spec change landed yet afaik. Also, this changes an interop 2023 test which should formally be approved to be added through an interop github issue.

@lilles lilles self-requested a review August 3, 2023 08:09
lilles
lilles requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@lilles lilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send a spec PR and raise an interop issue?

@zrhoffman
Copy link
Contributor

Send a spec PR

PRed w3c/css-houdini-drafts#1104

and raise an interop issue?

Raised #web-platform-tests/interop#389

@lilles lilles mentioned this pull request Aug 9, 2023
Open
zrhoffman added a commit to zrhoffman/wpt that referenced this pull request Dec 20, 2023
@zrhoffman
[css-properties-values-api] Add test coverage for <string> syntax in @…
b9afe05 
…Property

Probably this should not be merged until w3c/css-houdini-drafts#1103 is
resolved/the spec is updated.

Interop bug: web-platform-tests/interop#389

Test coverage for `<string>` syntax in `CSS.registerProperty` is in
web-platform-tests#41308.
@zrhoffman zrhoffman mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilles lilles lilles requested changes

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
css-properties-values-api mozilla:gecko-sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moz-wptsync-bot @lilles @zrhoffman @wpt-pr-bot