[css-properties-values-api] Add test coverage for <string> syntax in @property #43757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Property Probably this should not be merged until w3c/css-houdini-drafts#1103 is resolved/the spec is updated. Interop bug: web-platform-tests/interop#389 Test coverage for `<string>` syntax in `CSS.registerProperty` is in web-platform-tests#41308.
lilles
approved these changes
Jul 30, 2024
nt1m
added a commit
to nt1m/WebKit
that referenced
this pull request
Aug 5, 2024
https://bugs.webkit.org/show_bug.cgi?id=277655 rdar://133250776 Reviewed by NOBODY (OOPS!). Add support for `<string>` syntax as per: w3c/css-houdini-drafts@b8ff3ab WPT synced from: web-platform-tests/wpt#43757 * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html: * Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp: (WebCore::CSSCustomPropertySyntax::typeForTypeName): * Source/WebCore/css/parser/CSSCustomPropertySyntax.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): (WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
nt1m
added a commit
to nt1m/WebKit
that referenced
this pull request
Aug 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=277655 rdar://133250776 Reviewed by NOBODY (OOPS!). Add support for `<string>` syntax as per: w3c/css-houdini-drafts@b8ff3ab WPT synced from: web-platform-tests/wpt#43757 * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html: * Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp: (WebCore::CSSCustomPropertySyntax::typeForTypeName): * Source/WebCore/css/parser/CSSCustomPropertySyntax.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): (WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
webkit-commit-queue
pushed a commit
to nt1m/WebKit
that referenced
this pull request
Aug 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=277655 rdar://133250776 Reviewed by Darin Adler. Add support for `<string>` syntax as per: w3c/css-houdini-drafts@b8ff3ab WPT synced from: web-platform-tests/wpt#43757 * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property.html: * Source/WebCore/css/parser/CSSCustomPropertySyntax.cpp: (WebCore::CSSCustomPropertySyntax::typeForTypeName): * Source/WebCore/css/parser/CSSCustomPropertySyntax.h: * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeCustomPropertyValueWithSyntax): (WebCore::CSSPropertyParser::parseTypedCustomPropertyValue): Canonical link: https://commits.webkit.org/281872@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably this should not be merged until w3c/css-houdini-drafts#1103 is resolved/the spec is updated.
Interop bug: web-platform-tests/interop#389
Test coverage for
<string>syntax inCSS.registerPropertyis in #41308.