Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1849972] [wdspec] Only use local network in WebDriver BiDi's reload.py. #41661

Merged
merged 2 commits into from Aug 31, 2023

Conversation

moz-wptsync-bot
Copy link
Collaborator

Differential Revision: https://phabricator.services.mozilla.com/D186824

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1849972
gecko-commit: 24b824e226c5442350efdb6c5ba19cffb3bd6177
gecko-reviewers: webdriver-reviewers, jdescottes

@wpt-pr-bot wpt-pr-bot added infra webdriver-bidi wptrunner The automated test runner, commonly called through ./wpt run labels Aug 28, 2023
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw/KPltLqkdRP64u3jAjkYDGw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw/KPltLqkdRP64u3jAjkYDGw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-08-29T07:02:17.430Z

@community-tc-integration
Copy link

Uh oh! Looks like an error! Details

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw/CvSERwVSSa2WXYUJ7lFDBA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw/CvSERwVSSa2WXYUJ7lFDBA",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:taskcluster-github/ar7zdIKtRvmnHEg9GU0REw"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2023-08-29T07:02:50.375Z

@whimboo whimboo closed this Aug 30, 2023
@whimboo whimboo reopened this Aug 30, 2023
Differential Revision: https://phabricator.services.mozilla.com/D186824

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1849972
gecko-commit: 24b824e226c5442350efdb6c5ba19cffb3bd6177
gecko-reviewers: webdriver-reviewers, jdescottes
…ec tests.

Differential Revision: https://phabricator.services.mozilla.com/D186823

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1849972
gecko-commit: d8ac28803dd6c602871499b1fe1858f194f74a5d
gecko-reviewers: jdescottes
@whimboo
Copy link
Contributor

whimboo commented Aug 31, 2023

The chrome related failures can also be reproduced on the master branch and are not a regression from these changes. @jrandolf, @thiagowfx could you please have a look?

As such please admin merge the PR. CC @jgraham, @gsnedders, @DanielRyanSmith. Thanks

@whimboo
Copy link
Contributor

whimboo commented Aug 31, 2023

CC @web-platform-tests/admins for admin merge request. Please see my last comment why there are failures in the wpt-chrome-dev-stability job and that those are not related to this particular PR.

@sideshowbarker sideshowbarker merged commit 05f7563 into master Aug 31, 2023
39 of 41 checks passed
@sideshowbarker sideshowbarker deleted the gecko/1849972 branch August 31, 2023 11:22
@thiagowfx
Copy link
Member

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra mozilla:gecko-sync webdriver-bidi wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants