[WebDriver BiDi] Test undefined viewport #42713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AutomatedTester,
DanielRyanSmith,
foolip,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
jrandolf
changed the title
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
2 times, most recently
from
82aca69
to
21bf27f
Compare
OrKoN
reviewed
Oct 24, 2023
OrKoN
reviewed
Oct 24, 2023
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
2 times, most recently
from
8496a88
to
e6b26dc
Compare
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
3 times, most recently
from
267810b
to
d825448
Compare
OrKoN
reviewed
Oct 27, 2023
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
from
ffe34d7
to
d825448
Compare
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
2 times, most recently
from
d6f4c4d
to
9578b49
Compare
jrandolf
force-pushed
the
jrandolf/undefined
branch
3 times, most recently
from
68ac3fb
to
af38a92
Compare
whimboo
reviewed
Nov 9, 2023
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
from
29e2a3f
to
4800a25
Compare
OrKoN
reviewed
Nov 10, 2023
webdriver/tests/bidi/browsing_context/set_viewport/set_viewport.py
Outdated
Show resolved
Hide resolved
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
2 times, most recently
from
896bb92
to
35849b0
Compare
whimboo
requested changes
Nov 10, 2023
webdriver/tests/bidi/browsing_context/set_viewport/set_viewport.py
Outdated
Show resolved
Hide resolved
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
2 times, most recently
from
50c8983
to
ef12994
Compare
jrandolf
force-pushed
the
jrandolf/viewport_unchanged
branch
from
ef12994
to
aca7be3
Compare
OrKoN
approved these changes
Nov 16, 2023
whimboo
approved these changes
Nov 16, 2023
jrandolf
commented
Nov 16, 2023
jrandolf
commented
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for w3c/webdriver-bidi#571