Add noto fonts to the Docker image #42730
Conversation
|
c.f. #13203 We probably want full runs of Firefox and Chrome to compare results, because this will change results. |
|
https://packages.ubuntu.com/jammy/fonts-noto for those curious what is included in the fonts-noto meta package. |
This ensures that we have fallback glyphs for most/all characters. This affects some tests e.g. css/css-fonts/size-adjust-unicode-range-system-fallback.html (see https://bugzilla.mozilla.org/show_bug.cgi?id=1860124) Covering all of unicode does mean that we end up with a rather large increase in the docker image size. If this causes problems we could just install fonts-noto-cjk to fix the known breakage.
|
https://wpt.fyi/results/css/css-text/white-space?diff&filter=ADC&run_id=5167628194152448&run_id=5110012550053888 looks pretty sus in terms of regressions (CC @jfkthame) |
|
I think the things I'm most concerned about are https://wpt.fyi/results/?q=seq%28chrome%3Apass%20chrome%3Afail%29%20edge%3Apass&run_id=5167628194152448&run_id=5110012550053888&run_id=5196165500370944 (i.e., tests that have regressed in Chrome, but which currently pass in Edge—which we have for years ran with much larger font coverage).
|
I suspect this a genuine Chrome bug. The CSS Text spec says that control characters (that are not actually acting as such, like tab or newline) should render a visible glyph, not be invisible. Last I checked, Blink didn't ensure this; it just rendered the characters with whatever the current font is, which may result in a So it sounds like Chrome is simply using a Noto font where these control characters are invisible, which fails the tests that explicitly check for CC visibility. See also w3c/csswg-drafts#8261 |
|
https://wpt.fyi/results/?diff&filter=ADC&run_id=5085224079196160&run_id=5072232675540992 is the diff for Firefox with this change plus installing ffmpeg, which should hopefully not affect any of the same tests. There are a couple of possible regressions, but overall we end up passing more tests. |
|
@DanielRyanSmith can you review this for Chrome? |
This ensures that we have fallback glyphs for most/all characters. This affects some tests
e.g. css/css-fonts/size-adjust-unicode-range-system-fallback.html (see https://bugzilla.mozilla.org/show_bug.cgi?id=1860124)
Covering all of unicode does mean that we end up with a rather large increase in the docker image size. If this causes problems we could just install fonts-noto-cjk to fix the known breakage.