add part parser tests #43099
Closed
add part parser tests #43099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
reviewed
Nov 12, 2023
emilio
reviewed
Nov 12, 2023
| test_valid_selector("::part(foo):after"); | ||
| test_valid_selector("::part(foo)::after"); | ||
| test_valid_selector("::part(foo)::selection"); | ||
| test_valid_selector("::part(foo)::first-letter"); |
There was a problem hiding this comment.
first-letter is not tree-abiding right? If so it should be invalid
emilio
reviewed
Nov 12, 2023
| "::part(foo):is(:hover, :focus):not(:focus-within)::first-letter", | ||
| ); | ||
| test_valid_selector("::part(foo):lang(en)"); | ||
| test_valid_selector("::part(foo):dir(rtl)"); |
There was a problem hiding this comment.
I don't think this should be valid either... Lang/dir aren't user-action pseudo classes. but I need to check (tomorrow) what the spec ended up saying
keithamus
force-pushed
the
add-part-parser-tests
branch
from
8cf8964
to
36ef4bf
Compare
|
Closing this as this work ended up being done via #43490 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised there are some inconsistencies between the browsers when it comes to parsing
::part()pseudo selectors.(See also WICG/webcomponents#934)
/cc @emilio @nt1m @tabatkins because I'd really like some additional scrutiny here. I believe all of these should be valid/invalid selectors, but given browser support is mixed I'm not 100% confident.