[Gecko Bug 1866431] Send full codepoints when creating key events #43722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, given a string in element send keys, we iterated over each UCS2 "character" in the string, so that non-BMP characters ended up as separate key events, one for the high surrogate and one for the low surrogate. With this change we instead use the built in string iterator which provides the surrogate pair in the case of non-BMP characters, so we emit a single event for each unicode codepoint. Differential Revision: https://phabricator.services.mozilla.com/D196220 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1866431 gecko-commit: f19c3570bc57265bbb5ba139efdb1dcb53a328bc gecko-reviewers: webdriver-reviewers, masayuki, whimboo
wpt-pr-bot
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, given a string in element send keys, we iterated over each
UCS2 "character" in the string, so that non-BMP characters ended up as
separate key events, one for the high surrogate and one for the low
surrogate.
With this change we instead use the built in string iterator which
provides the surrogate pair in the case of non-BMP characters, so we
emit a single event for each unicode codepoint.
Differential Revision: https://phabricator.services.mozilla.com/D196220
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1866431
gecko-commit: f19c3570bc57265bbb5ba139efdb1dcb53a328bc
gecko-reviewers: webdriver-reviewers, masayuki, whimboo