URL: backslash after authority for special URLs #44637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
approved these changes
Feb 16, 2024
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Feb 17, 2024
… the host https://bugs.webkit.org/show_bug.cgi?id=265484 rdar://119219832 Reviewed by Alex Christensen. Thanks to dave caruso for reporting and suggesting a fix. Tests are synchronized up to and including this PR: web-platform-tests/wpt#44637 * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/failure.html: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.worker-expected.txt: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::parse): * Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/274915@main
aperezdc
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Mar 11, 2024
…gi?id=265484 URLParser should parse URLs including authority and a backslash after the host https://bugs.webkit.org/show_bug.cgi?id=265484 rdar://119219832 Reviewed by Alex Christensen. Thanks to dave caruso for reporting and suggesting a fix. Tests are synchronized up to and including this PR: web-platform-tests/wpt#44637 * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/failure.html: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.worker-expected.txt: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::parse): * Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/274915@main Canonical link: https://commits.webkit.org/274313.38@webkitglib/2.44
aperezdc
pushed a commit
to WebKit/WebKit
that referenced
this pull request
Mar 15, 2024
…gi?id=265484 URLParser should parse URLs including authority and a backslash after the host https://bugs.webkit.org/show_bug.cgi?id=265484 rdar://119219832 Reviewed by Alex Christensen. Thanks to dave caruso for reporting and suggesting a fix. Tests are synchronized up to and including this PR: web-platform-tests/wpt#44637 * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-origin-xhtml-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/a-element_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/failure.html: * LayoutTests/imported/w3c/web-platform-tests/url/resources/urltestdata.json: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any.worker_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_exclude=(file_javascript_mailto)-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-constructor.any_include=file-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-origin.any.worker-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.js: * LayoutTests/imported/w3c/web-platform-tests/url/url-statics-canparse.any.worker-expected.txt: * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::parse): * Tools/TestWebKitAPI/Tests/WTF/URLParser.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/274915@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.