DOM: Add WPTs for removing steps #44774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This CL adds WPTs for removing steps, to ensure that script is never
executed during the removing steps hook [1], which are invoked
synchronously during per-node removal (that is, they are not batched,
but run this way per-node).
This CL:
1. Augments the existing iframe removing steps WPT, to include
`pagehide` events. At the time of writing this, all browsers deviate
from the HTML Standard, and fail this test.
2. Adds new tests for `<input>` and `<button>` to assert that when they
are focused and subsequently removed from the DOM, the `blur` event
is *not* fired, per the HTML Standard. Chromium fails this test,
while Safari and Firefox pass it.
[1]: https://dom.spec.whatwg.org/#concept-node-remove-ext
Bug: 40150299
Change-Id: I0aa43755ccac8ea432056800c5c4167d8e4460e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323158
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1266801}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5323158
branch
from
26662db
to
0be97ae
Compare
wpt-pr-bot
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds WPTs for removing steps, to ensure that script is never
executed during the removing steps hook 1, which are invoked
synchronously during per-node removal (that is, they are not batched,
but run this way per-node).
This CL:
pagehideevents. At the time of writing this, all browsers deviatefrom the HTML Standard, and fail this test.
\<input>and\<button>to assert that when theyare focused and subsequently removed from the DOM, the
blureventis not fired, per the HTML Standard. Chromium fails this test,
while Safari and Firefox pass it.
Bug: 40150299
Change-Id: I0aa43755ccac8ea432056800c5c4167d8e4460e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5323158
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1266801}