Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch: remove usage of FileReader #44893

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Fetch: remove usage of FileReader #44893

merged 2 commits into from
Mar 3, 2024

Conversation

KhafraDev
Copy link
Contributor

Node doesn't implement FileReader and the repo where fetch tests are run
will soon be removing its FileReader shim.

@KhafraDev
Fetch: remove usage of FileReader
79eca68 
Node doesn't implement FileReader and the repo where fetch tests are run
will soon be removing its FileReader shim.
@KhafraDev KhafraDev mentioned this pull request Mar 1, 2024
Closed
annevk
annevk reviewed Mar 3, 2024
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but please tidy this up a tiny bit more then to

return bodyAsBlob.text().then(...

annevk
annevk approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, thanks!

@annevk annevk enabled auto-merge (squash) March 3, 2024 14:57
@annevk annevk merged commit 0a24e44 into web-platform-tests:master Mar 3, 2024
17 checks passed
@KhafraDev KhafraDev deleted the fetch-remove-filereader branch March 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@jdm jdm Awaiting requested review from jdm

@mnot mnot Awaiting requested review from mnot

@youennf youennf Awaiting requested review from youennf

@yutakahirano yutakahirano Awaiting requested review from yutakahirano

Assignees

@youennf youennf

Labels
fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KhafraDev @annevk @youennf @wpt-pr-bot