Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few missing post-insertion-step tests #44906

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Add a few missing post-insertion-step tests #44906

merged 4 commits into from
Mar 6, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 4, 2024

  • Check that a script runs after the <meta name=referrer> is applied
  • Check that a script runs after a form with a pre-exisiting associated input is inserted

@noamr noamr changed the title Add insertion step for meta with referrer+script Add a few missing post-insertion-step tests Mar 4, 2024
Copy link
Member

@domfarolino domfarolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! LGTM % one optional naming nit

@@ -0,0 +1,22 @@
<!doctype html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically these aren't using appendChild anymore I guess heh. Idk if we want to update the name of the test files or not, up to you. Just wanted to point that out since it feels a little redundant and is technically not accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

…to Node-append-form-and-script-from-fragment.tentative.html
…ive.html to Node-append-meta-referrer-and-script-from-fragment.tentative.html
@noamr noamr enabled auto-merge (squash) March 6, 2024 16:36
@noamr noamr merged commit 951096a into master Mar 6, 2024
17 checks passed
@noamr noamr deleted the insertion-ref branch March 6, 2024 16:54
BruceDai pushed a commit to BruceDai/wpt that referenced this pull request Mar 25, 2024
* Add insertion step for meta with referrer+script

* Added form association test

* Rename Node-appendChild-form-and-script-from-fragment.tentative.html to Node-append-form-and-script-from-fragment.tentative.html

* Rename Node-appendChild-meta-referrer-and-script-from-fragment.tentative.html to Node-append-meta-referrer-and-script-from-fragment.tentative.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants