Use email.utils.parsedate_to_datetime to parse RFC (2)822 dates #46042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After c3a572d, checking the key cert via OpenSSL failed with a mismatch between aware and naive datetime objects. This happened because strptime creates a naive datetime object even when "%Z" is in the format string. Instead, use the RFC 2822 date parser in email.utils, as this is the output format of OpenSSL, which produces an aware datetime object.
JonWBedard
approved these changes
May 2, 2024
foolip
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After c3a572d, checking the key cert via OpenSSL failed with a mismatch between aware and naive datetime objects. This happened because strptime creates a naive datetime object even when "%Z" is in the format string.
Instead, use the RFC 2822 date parser in email.utils, as this is the output format of OpenSSL, which produces an aware datetime object.
Fixes #46040.