Add a REFERENCE-IN-OTHER-TYPE lint #46120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
boggydigital,
cbiesinger,
DanielRyanSmith,
dbaron,
dirkschulze,
ewilligers,
fantasai,
foolip,
fred-wang,
FremyCompany,
frivoal,
fsoder,
gregwhitworth and
kojiishi
nt1m
reviewed
May 7, 2024
jgraham
approved these changes
May 10, 2024
| @@ -2,7 +2,6 @@ | |||
| <link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org"> | |||
| <link rel="help" href="https://www.w3.org/TR/css-break-3/#transforms"> | |||
| <link rel="help" href="https://www.w3.org/TR/CSS22/visuren.html#relative-positioning"> | |||
There was a problem hiding this comment.
I feel like this test would benefit from a "testharness is a child of <head>" lint :p
There was a problem hiding this comment.
They are in the head. An explicit head tag is optional in HTML.
There was a problem hiding this comment.
No, the <div> below implicitly closes head and creates a body.
See:
According to the manifest these are all testharness tests, but WebKit's historic slightly different logic has led to these being run in a bogus state previously (where they were treated as both a reftest and a testharness test all at once).
It's not overly meaningful to have a reference while also being manual, and all this is really testing is that the click event is fired, so let's just turn this into a testharness test using testdriver.
We already check whether tests crash, so we may as well check the rendering too.
This is similar to the TESTHARNESS-IN-OTHER-TYPE lint
wpt-pr-bot
requested review from
mstensho,
nikosandronikos,
plinss,
rachelandrew,
shallawa,
svgeesus and
tabatkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46058, and fixes a bunch of the failures it catches.