[wptrunner] Optimize server test order #46331
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestEnvironment.ensure_started()` synchronously polls that all servers are started. The non-webtransport-h3 servers are often tested first and immediately fail with "Connection refused", which puts them in the `pending` list. This spins the polling loop at least once and delays startup by at least 0.5s. Run the webtransport-h3 server test first, which blocks [1]. This provides additional time for the non-webtransport-h3 servers to become ready, which means the `TestEnvironment` often only needs to poll once. This speeds up `ensure_started()` from ~2.2s -> ~1.7s and improves wptrunner's interactive UX (https://crbug.com/339299999). No functional change. [1]: https://github.com/web-platform-tests/wpt/blob/431f8d35/tools/webtransport/h3/webtransport_h3_server.py#L593
wpt-pr-bot
added
infra
wptrunner
WeizhongX
approved these changes
May 16, 2024
|
The failures afflict other PRs (e.g., #46333, #46292), so it's unlikely this very narrow PR is the culprit. Also, the Azure versions of the tests are all green. @KyleJu @DanielRyanSmith Can either of you please admin merge? Thanks! |
DanielRyanSmith
merged commit c6298d4
into
web-platform-tests:master
32 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestEnvironment.ensure_started()synchronously polls that all servers are started. The non-webtransport-h3 servers are often tested first and immediately fail with "Connection refused", which puts them in thependinglist. This spins the polling loop at least once and delays startup by at least 0.5s.Run the webtransport-h3 server test first, which blocks. This provides additional time for the non-webtransport-h3 servers to become ready, which means the
TestEnvironmentoften only needs to poll once.This speeds up
ensure_started()from ~2.2s -> ~1.7s and improves wptrunner's interactive UX (https://crbug.com/339299999). No functional change.