Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting <input type=file>.files #6617

Merged
merged 2 commits into from Aug 2, 2017
Merged

Setting <input type=file>.files #6617

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c300c3
Setting <input type=file>.files
annevk Jul 25, 2017
73ab423
test a bit more
annevk Aug 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions html/semantics/forms/the-input-element/files.html
View file
Open in desktop
Expand Up @@ -45,4 +45,22 @@
var files = input.files;
assert_equals(input.files, files, "files should return the same object");
}, "files for input type=file");

test(() => {
const i1 = document.createElement("input"),
i2 = document.createElement("input");
i1.type = "file";
i2.type = "file";

const files = i2.files;
i1.files = i2.files;
assert_equals(i1.files, files);
assert_equals(i2.files, files);

i1.files = null;
assert_equals(i1.files, files);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all these different cases should be separate tests, or at the very least should have nice assertion messages.


assert_throws(new TypeError(), () => i1.files = []);
assert_throws(new TypeError(), () => i1.files = [new File([], "x")]);
}, "setting <input type=file>.files");
</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also test the "does not apply" setter case.