Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting <input type=file>.files #6617

Merged
merged 2 commits into from Aug 2, 2017
Merged

Setting <input type=file>.files #6617

merged 2 commits into from Aug 2, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented Jul 25, 2017 •
edited by wpt-pr-bot

@annevk annevk mentioned this pull request Jul 25, 2017
Merged
@w3c-bots
Copy link

w3c-bots commented Jul 25, 2017 •
edited

View the complete job log.

Firefox (nightly)

@w3c-bots
Copy link

w3c-bots commented Jul 25, 2017 •
edited

View the complete job log.

Sauce (safari)

@w3c-bots
Copy link

w3c-bots commented Jul 25, 2017 •
edited

View the complete job log.

Chrome (unstable)

@w3c-bots
Copy link

w3c-bots commented Jul 25, 2017 •
edited

View the complete job log.

Sauce (MicrosoftEdge)

@sideshowbarker
Copy link
Contributor

w3c-test:mirror

domenic
domenic requested changes Aug 1, 2017
View reviewed changes
html/semantics/forms/the-input-element/files.html Outdated
assert_equals(i2.files, files);

i1.files = null;
assert_equals(i1.files, files);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all these different cases should be separate tests, or at the very least should have nice assertion messages.

html/semantics/forms/the-input-element/files.html Outdated

assert_throws(new TypeError(), () => i1.files = []);
assert_throws(new TypeError(), () => i1.files = [new File([], "x")]);
}, "setting <input type=file>.files");
</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also test the "does not apply" setter case.

@annevk annevk requested a review from domenic August 2, 2017 09:25
@annevk annevk merged commit e16cb82 into master Aug 2, 2017
@annevk annevk deleted the annevk/filelist branch August 2, 2017 12:49
annevk added a commit to whatwg/html that referenced this pull request Aug 2, 2017
@annevk
Make <input type=file>.files settable
5dc7db2 
Tests: web-platform-tests/wpt#6617.

Fixes #2861.
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
@annevk
Make <input type=file>.files settable
e625ba9 
Tests: web-platform-tests/wpt#6617.

Fixes whatwg#2861.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@ayg ayg Awaiting requested review from ayg

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees
No one assigned
Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@annevk @w3c-bots @sideshowbarker @domenic @wpt-pr-bot