Add generation for "ahem-mismatch.html" #8396
Conversation
rwaldron
changed the title
| }""".strip() | ||
| style_table_no_font = """ | ||
| table { | ||
| font: 15px/1; |
There was a problem hiding this comment.
This declaration is invalid (you can't omit the font-family); we should probably just have font-size: 15px; line-height: 1; in this case.
Build PASSEDStarted: 2017-11-22 16:44:18 View more information about this build on: |
|
|
||
| return "".join(rv) | ||
| def build_link(is_mismatch): | ||
| return ('<link rel="%s" href="ahem-ref.html">' %("mismatch" if is_mismatch else "match")) |
There was a problem hiding this comment.
I would suggest having <link rel=match href=ahem-ref.html> in ahem.html, and <link rel=mismatch href=ahem-notref.html> in ahem-ref.html. What we're really trying to assert here with the mismatch ref is that ahem-ref.html is rendered correctly, rather than actually creating a new test per se.
| } | ||
| table { | ||
| font-size: 15px; | ||
| line-height: 1; |
There was a problem hiding this comment.
@gsnedders fixup here, per review.
| <!doctype html> | ||
| <title>Ahem checker</title> | ||
| <link rel="mismatch" href="ahem-notref.html"> |
There was a problem hiding this comment.
@gsnedders fixup here, per review.
|
Blergh, doing the squash merge I forgot to change the summary line away from the title of the PR, so it refers to a non-existent file. Oh well. The changes look good, at least! Thanks! |
|
@gsnedders that's no problem—thanks again for the reviews! |
No description provided.