Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cut/paste errors; added new reftests for lab #8538

Merged
merged 1 commit into from
May 3, 2018
Merged

Fixed cut/paste errors; added new reftests for lab #8538

merged 1 commit into from
May 3, 2018

Conversation

faceless2
Copy link
Contributor

@faceless2 faceless2 commented Dec 1, 2017

Some of the tests under css-color had cut-n-paste errors;

  • the lab tests were referencing the "blacktest-ref.html" instead of a correct reftest (which I created)
  • the rgb hex value 008000 had incorrectly been matched to rgb(0, 80, 0) - should be 128
  • several of the lch tests had been copied from lab tests, but had not had the function changed from lab->lch

@w3c-bots
Copy link

w3c-bots commented Dec 1, 2017

Build PASSED

Started: 2017-12-01 17:15:04
Finished: 2017-12-01 17:26:51

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@csnardi
Copy link
Member

csnardi commented Dec 4, 2017

I only skimmed the lab/lch changes, but all of the rgb changes look good.

@dbaron
Copy link
Member

dbaron commented Dec 4, 2017

I'm hoping @svgeesus can review this one.

@csnardi
Copy link
Member

csnardi commented Dec 18, 2017

Assuming all of the reference styles are correct in the tests themselves, this all looks good to me.

@csnardi
Copy link
Member

csnardi commented Jan 10, 2018

@svgeesus Would you also mind taking a look at this change? I'm working on Color 4 implementation with RGB, and I'd like to make sure these tests are passing.

@frivoal frivoal added the wg-css label Apr 30, 2018
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all correct. My apologies for the sloppy original tests and also for not noticing the review mention until recently.

@svgeesus svgeesus merged commit 7f84923 into web-platform-tests:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants