Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a testharness.js test fail to see if Travis will notice #8773

Closed
wants to merge 1 commit into from

Conversation

foolip
Copy link
Member

@foolip foolip commented Dec 21, 2017

This change is Reviewable

@w3c-bots
Copy link

w3c-bots commented Dec 21, 2017

Build BROKEN

Started: 2017-12-21 10:08:24
Finished: 2017-12-21 10:09:08

Failing Jobs

  • resources_unittest in py27

View more information about this build on:

@foolip
Copy link
Member Author

foolip commented Dec 21, 2017

Cool, it does actually fail. @jugglinmike, FYI, I saw these test failures locally using Python 2.7.9 and Firefox 57.0.1:

::Test#add_cleanup <- . PASSED                                                                                                    [  2%]
::Test#add_cleanup reported count <- . PASSED                                                                                     [  5%]
::Test#add_cleanup: error <- . PASSED                                                                                             [  8%]
::Test#add_cleanup: multiple functions with one in error <- . PASSED                                                              [ 10%]
::Sample HTML5 API Tests <- . PASSED                                                                                              [ 13%]
::Sample HTML5 API Tests <- . PASSED                                                                                              [ 16%]
::Sample HTML5 API Tests <- . PASSED                                                                                              [ 18%]
::Test#force_timeout <- . PASSED                                                                                                  [ 21%]
::Sample for using generate_tests to create a series of tests that share the same callback. <- . PASSED                           [ 24%]
::Example with iframe that notifies containing document via callbacks <- . PASSED                                                 [ 27%]
::Example with iframe that consolidates errors via fetch_tests_from_window <- . PASSED                                            [ 29%]
::Example with iframe that consolidates tests via fetch_tests_from_window <- . FAILED                                             [ 32%]
::Example with iframe that notifies containing document via cross document messaging <- . PASSED                                  [ 35%]
::Ordering <- . PASSED                                                                                                            [ 37%]
::Async Tests and Promises <- . FAILED                                                                                            [ 40%]
::Promise Tests <- . FAILED                                                                                                       [ 43%]
::Example with file_is_test (should fail) <- . PASSED                                                                             [ 45%]
::Example single page test with no asserts <- . PASSED                                                                            [ 48%]
::Example single page test with no body <- . PASSED                                                                               [ 51%]
::Example with file_is_test <- . PASSED                                                                                           [ 54%]
::Harness Handling Uncaught Exception <- . PASSED                                                                                 [ 56%]
::Harness Ignoring Uncaught Exception <- . PASSED                                                                                 [ 59%]
::Dedicated Worker Tests <- . PASSED                                                                                              [ 62%]
::Example with a service worker <- . PASSED                                                                                       [ 64%]
::Example with a shared worker <- . PASSED                                                                                        [ 67%]
::idlharness basic <- . PASSED                                                                                                    [ 70%]
::IdlArray.prototype.is_json_type() <- . PASSED                                                                                   [ 72%]
::IdlDictionary.prototype.get_inheritance_stack() <- . PASSED                                                                     [ 75%]
::IdlDictionary.prototype.default_to_json_operation() <- . PASSED                                                                 [ 78%]
::IdlInterface.prototype.get_inheritance_stack() <- . PASSED                                                                      [ 81%]
::IdlInterface.prototype.has_default_to_json_regular_operation() <- . PASSED                                                      [ 83%]
::IdlInterface.prototype.has_to_json_regular_operation() <- . PASSED                                                              [ 86%]
::idlharness: Immutable prototypes <- . PASSED                                                                                    [ 89%]
::idlharness: Primary interface <- . PASSED                                                                                       [ 91%]
::IdlInterface.prototype.test_to_json_operation() <- . PASSED                                                                     [ 94%]
::IdlDictionary.prototype.traverse_inherited_and_consequential_interfaces() <- . PASSED                                           [ 97%]
::IdlInterfaceMember.prototype.is_to_json_regular_operation() <- . PASSED                                                         [100%]

That made me wonder if these tests are being exercised at all, but they are.

@foolip foolip closed this Dec 21, 2017
@foolip foolip deleted the deliberate-failure branch December 21, 2017 10:18
@foolip
Copy link
Member Author

foolip commented Dec 21, 2017

Aha, it works locally with Firefox Nightly. That confirms that the Python 2.7.9 bit in #8774 is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants