Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch external_host to host_ip. #9258

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@jgraham
Copy link
Contributor

jgraham commented Jan 30, 2018

When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.

In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Jan 30, 2018

@wpt-pr-bot wpt-pr-bot requested a review from gsnedders Jan 30, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 30, 2018

Build PASSED

Started: 2018-02-22 15:19:17
Finished: 2018-02-22 15:35:43

View more information about this build on:

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 9, 2018

@jgraham can you rebase?

Switch external_host to host_ip.
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.

In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.

@jgraham jgraham force-pushed the host_ip branch from 40451e2 to 22b9e13 Feb 22, 2018

@gsnedders

This comment has been minimized.

Copy link
Contributor

gsnedders commented Feb 23, 2018

Hmm, I'm still not entirely happy with "host" and "host_ip"; I think that's still confusing for the same reason as "external_host" is confusing. (Ultimately, a lot of this could be solved by actually documenting our config file!).

To me, "server_host" in place of "external_host" and "browser_host" in place of "host" would be clearest, though as per on IRC you disagree.

@jgraham

This comment has been minimized.

Copy link
Contributor Author

jgraham commented Feb 23, 2018

Let's deal with another raound of renaming in a followup, since this fixes the original problem @bzbarsky was experiencing.

@gsnedders gsnedders merged commit 1ccd332 into master Feb 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the host_ip branch Feb 23, 2018

@jgraham jgraham restored the host_ip branch Feb 23, 2018

jgraham added a commit that referenced this pull request Feb 23, 2018

jgraham added a commit that referenced this pull request Feb 23, 2018

jgraham added a commit that referenced this pull request Feb 23, 2018

Switch external_host to host_ip. (#9258)
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.

In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.

jgraham added a commit that referenced this pull request Feb 23, 2018

jgraham added a commit that referenced this pull request Mar 2, 2018

Switch external_host to host_ip. (#9258)
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.

In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.

gsnedders added a commit that referenced this pull request Mar 2, 2018

Switch external_host to host_ip. (#9258)
When running tests in Firefox we don't require that the hostname is
actually resolvable since we set up some internal DNS overrides. This
means that we don't actually need to have web-platform.test defined in
/etc/hosts. As a consequence when we check the server is responding,
the check will typically fail for Firefox developers if we try to
access by hostname. Previously we made use of a special dance in which
external_host held the ip at the point of the check and was later
replaced by host to actually run tests. But that changed, and instead
we relied on the fact that we (accidentially) didn't actually fail in
the case the servers couldn't be reached by host name. However in some
cases things still failed because local DNS resolved web-patform.test
to some ip address, causing hangs or other badness.

In this patch we simply add a host_ip property to the config, and
connect to that to test the servers are repopnsing rather than the
hostname. We also actually fil if we didn't manage to connect to all
the servers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.