Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional test for readAsBinaryString #9302

Merged
merged 2 commits into from Feb 1, 2018
Merged

Add functional test for readAsBinaryString #9302

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70649bb
Add functional test for readAsBinaryString
xiuqijix Jan 31, 2018
bb7456c
Use step_func_done()to avoid having to invoke done()
xiuqijix Feb 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 33 additions & 0 deletions FileAPI/reading-data-section/filereader_readAsBinaryString.html
View file
Open in desktop
@@ -0,0 +1,33 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>FileAPI Test: filereader_readAsBinaryString</title>
<link rel="author" title="Intel" href="http://www.intel.com">
<link rel="help" href="https://w3c.github.io/FileAPI/#readAsBinaryString">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>

async_test(t => {
const blob = new Blob(["σ"]);
const reader = new FileReader();

reader.onload = t.step_func(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you can use step_func_done() to avoid having to invoke done().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @annevk, update the nit issue, PTAL.

assert_equals(typeof reader.result, "string", "The result is string");
assert_equals(reader.result.length, 2, "The result length is 2");
assert_equals(reader.result, "\xcf\x83", "The result is \xcf\x83");
assert_equals(reader.readyState, reader.DONE);
t.done();
});

reader.onloadstart = t.step_func(() => {
assert_equals(reader.readyState, reader.LOADING);
});

reader.onprogress = t.step_func(() => {
assert_equals(reader.readyState, reader.LOADING);
});

reader.readAsBinaryString(blob);
});

</script>