Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that resources fetched by cross-origin CSS are not in the timeline #9307

Merged

Conversation

@yoavweiss
Copy link
Contributor

yoavweiss commented Jan 31, 2018

Closes w3c/resource-timing#70

This is a long standing missing test. Seems like all browsers are doing the wrong thing here, which leads me to think we may need to change the spec...

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 31, 2018

Build PENDING

Started: None
Finished: None

View more information about this build on:

@igrigorik

This comment has been minimized.

Copy link
Member

igrigorik commented Jan 31, 2018

This is a long standing missing test. Seems like all browsers are doing the wrong thing here, which leads me to think we may need to change the spec...

Mozilla claims to have address this in https://bugzilla.mozilla.org/show_bug.cgi?id=1180145 — is the test still failing for you? On Chrome side, see: https://bugs.chromium.org/p/chromium/issues/detail?id=532399#c32 — it seems like we still don't have agreement on w3c/ServiceWorker#719.

/cc @annevk @toddreifsteck @rniwa

@yoavweiss

This comment has been minimized.

Copy link
Contributor Author

yoavweiss commented Jan 31, 2018

I see this test failing in the latest Firefox nightly.

I agree that if this information is exposed through Service Workers, there's no point in blocking this info from Resource Timing.

@annevk

This comment has been minimized.

Copy link
Member

annevk commented Jan 31, 2018

@jwatt and @wanderview can maybe help out here. I think our position is that we'd rather block it where possible, even if it's inconsistent.

@wpt-pr-bot wpt-pr-bot requested review from inexorabletash, jdashg and jdm Jan 2, 2019

@yoavweiss

This comment has been minimized.

Copy link
Contributor Author

yoavweiss commented Jan 2, 2019

I've rebased and updated the test to include an @import test.

Safari Tech Preview seems to pass the test.
Firefox nightly still fails because fonts are present in the timeline. There's an open issue on that front.

@yoavweiss yoavweiss force-pushed the yoavweiss:resource_timing_css_cors branch from f1012e7 to 8eac7a5 Jan 2, 2019

@domenic domenic removed their request for review Jan 2, 2019

@wpt-pr-bot wpt-pr-bot requested a review from fantasai Jan 2, 2019

@yoavweiss

This comment has been minimized.

Copy link
Contributor Author

yoavweiss commented Jan 3, 2019

Commented on the flakiness in the related bug

@cvazac

cvazac approved these changes Jan 3, 2019

@yoavweiss yoavweiss merged commit 18f379e into web-platform-tests:master Jan 3, 2019

2 checks passed

Taskcluster (pull_request) TaskGroup: success
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@yoavweiss yoavweiss deleted the yoavweiss:resource_timing_css_cors branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.