Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave out the default value when serializing font-feature-settings #9328

Merged
merged 1 commit into from Feb 1, 2018

Commits on Feb 1, 2018

  1. Leave out the default value when serializing font-feature-settings

    According to the shortest-serialization principle [1], values should be
    omitted if their omission wouldn't change the value of reparsing. As
    "1"/"on" is the default value for font-feature-settings, omit this when
    serializing, matching the behavior of Firefox.
    
    [1]: w3c/csswg-drafts#1564
    
    Bug: 807744
    Change-Id: Ieb8b86aa66aa303a82a895c42373177cf7f13d07
    Reviewed-on: https://chromium-review.googlesource.com/896203
    Reviewed-by: Darren Shen <shend@chromium.org>
    Commit-Queue: Chris Nardi <cnardi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#533566}
    csnardi authored and chromium-wpt-export-bot committed Feb 1, 2018
    Copy the full SHA
    24e7b04 View commit details
    Browse the repository at this point in the history